Skip to content

fix: WP 6.9 Compatibility#3654

Merged
bfintal merged 2 commits intodevelopfrom
fix/wp-6.9-compatibility
Dec 10, 2025
Merged

fix: WP 6.9 Compatibility#3654
bfintal merged 2 commits intodevelopfrom
fix/wp-6.9-compatibility

Conversation

@kaeizen
Copy link
Contributor

@kaeizen kaeizen commented Dec 3, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Bug Fixes
    • Prevented visual flicker when text auto-resizes inside stacked/layout blocks, improving on-screen stability.
    • Restored consistent editor toolbar visibility for default text blocks in newer WordPress versions, avoiding unexpected hiding.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 3, 2025 •
edited
Loading

Walkthrough

Added CSS rules to disable font-size transitions for Core Stretchy Paragraphs inside Stackable blocks (frontend and editor) to prevent flicker, and added role attributes to text block attributes to keep the toolbar visible in WP 6.9+ when the text block is default.

Changes

Cohort / File(s) Summary
Flicker prevention (frontend + editor)
src/styles/block-transitions.scss, src/styles/editor-block-transitions.scss		 Added rules to disable font-size transitions for .stk-block .has-fit-text under body.stk--anim-init and within .editor-styles-wrapper, with comments about WP 6.9 compatibility and flicker mitigation.
Text attribute role addition
src/block-components/typography/attributes.js		 Added role: 'content' and __experimentalRole: 'content' to the text attribute when hasTextContent is true to prevent the toolbar from being hidden in WP 6.9+; no other API or signature changes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Review CSS selectors to ensure specificity and no unintended overrides in editor and frontend.
  • Verify attributes.js additions don't conflict with existing block attribute handling or linting rules.
  • Check comments referencing WP 6.9 for accuracy and future clarity.

Poem

🐇✨ I hopped through styles and attributes today,
Turned off a font flicker that ruined the play.
I nudged a role so the toolbar would stay,
Editor and page now calm in their way—
A tiny rabbit patch, steady and gay.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: WP 6.9 Compatibility' clearly summarizes the main objective of the changeset, which addresses WordPress 6.9 compatibility issues across multiple files (block transitions, editor styles, and typography attributes).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/wp-6.9-compatibility
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0d281a0 and f9ad7ab.

📒 Files selected for processing (1)
  • src/block-components/typography/attributes.js (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: PHP 8.2 and WP latest
  • GitHub Check: PHP 8.2 and WP 6.7.2
  • GitHub Check: PHP 7.3 and WP 6.5.5
  • GitHub Check: PHP 7.3 and WP latest
  • GitHub Check: PHP 8.2 and WP 6.6.2
  • GitHub Check: PHP 8.2 and WP 6.5.5
  • GitHub Check: build
🔇 Additional comments (1)
src/block-components/typography/attributes.js (1)

88-94: WP 6.9 RichText role configuration looks reasonable; confirm editor‑only impact and API match

This aligns with the Gutenberg PR comment (using role / __experimentalRole set to 'content' on the text field) and is nicely documented in the inline comment. Two things to double‑check:

  • Ensure role="content" does not end up on the frontend markup, since content is not a standard ARIA role and should remain an editor‑only hint.
  • Confirm that placing role / __experimentalRole inside this attribute definition matches how WP 6.9+ expects these props to be wired, to avoid regressions when Gutenberg internals change.

If both assumptions hold in your WP 6.9 tests, this change looks good.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025 •
edited
Loading

🤖 Pull request artifacts

file commit
pr3654-stackable-3654-merge.zip f9ad7ab

github-actions bot added a commit that referenced this pull request Dec 3, 2025
@github-actions
Upload pr3654-stackable-3654-merge.zip (0d281)
9f7ebd4 
Pull request: #3654
Commit: 0d281a0
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Try this Pull Request in the WordPress playground: https://playground.wordpress.net/?mode=seamless#{"landingPage":"/wp-admin/post-new.php?post_type=page","preferredVersions":{"php":"latest","wp":"latest"},"steps":[{"step":"login","username":"admin","password":"password"},{"step":"installPlugin","pluginZipFile":{"resource":"url","url":"https://raw.githubusercontent.com/gambitph/Stackable/artifacts/pr3654-stackable-3654-merge.zip"}}]}

@kaeizen kaeizen self-assigned this Dec 3, 2025
github-actions bot added a commit that referenced this pull request Dec 5, 2025
@github-actions
Upload pr3654-stackable-3654-merge.zip (f9ad7)
21fed33 
Pull request: #3654
Commit: f9ad7ab
@bfintal bfintal merged commit 45a50e3 into develop Dec 10, 2025
8 of 9 checks passed
@bfintal bfintal deleted the fix/wp-6.9-compatibility branch December 10, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kaeizen kaeizen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kaeizen @bfintal